rpc: set max-concurrent streams to math.MaxInt32 #14785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tamird
approved these changes
Apr 11, 2017
pkg/rpc/context.go
Outdated
| // server value so that we have no fixed limit on the number of concurrent | ||
| // streams/requests on either the client or server. | ||
| // | ||
| // TODO(peter): This setting should be revisited. |
There was a problem hiding this comment.
it'd be helpful to elaborate on this - when? why? with what additional evidence?
There was a problem hiding this comment.
Removed the TODO. I'm going to see if there is an issue about limits at the SQL level.
petermattis
force-pushed
the
pmattis/max-concurrent-streams
branch
from
5993e0d to
c9c17cd
Compare
The max-concurrent streams setting affects how many concurrent streams/unary-RPCs are allowed on the server and this setting is propagated across to the client connection. The default client connection max-streams setting is 100 which seems unreasonably low and may be contributing to high latencies. Fixes cockroachdb#14769
petermattis
force-pushed
the
pmattis/max-concurrent-streams
branch
from
c9c17cd to
636448d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max-concurrent streams setting affects how many concurrent
streams/unary-RPCs are allowed on the server and this setting is
propagated across to the client connection. The default client
connection max-streams setting is 100 which seems unreasonably low and
may be contributing to high latencies.
Fixes #14769