storage: Minor code cleanups

[a-robinson]

• Add more detail to Fatal log message hit by stability: crash on uninitialized replica #14193
• Improve nasty indentation in processRaftRequest by moving the error
  check above the normal code path
• Fix removePlaceholderLocked method comment

@tamird

---

This change is 

[tamird]

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

pkg/storage/store.go, line 2985 at r1 (raw file):

	// Snapshots addressed to replica ID 0 are permitted; this is the
	// mechanism by which preemptive snapshots work.
	// No other requests to replica ID 0 are allowed.

separate this with an empty comment line

---

pkg/storage/store.go, line 2992 at r1 (raw file):

			// only way we can get here is if the replica did not previously exist.
			if log.V(1) {
				log.Infof(ctx, "refusing incoming Raft message %s from %+v to %+v",

nit: log.VEventf while you're here

---

pkg/storage/store.go, line 2997 at r1 (raw file):

			return roachpb.NewErrorf(
				"cannot recreate replica that is not a member of its range (StoreID %s not found in r%d)",
				r.store.StoreID(), req.RangeID)

nit: closing paren on the next line for symmetry

---

Comments from Reviewable

[a-robinson]

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

---

pkg/storage/store.go, line 2985 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

separate this with an empty comment line

Done.

---

pkg/storage/store.go, line 2992 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

nit: log.VEventf while you're here

Done.

---

pkg/storage/store.go, line 2997 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

nit: closing paren on the next line for symmetry

Done.

---

Comments from Reviewable

[tamird]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from Reviewable