crosscluster/logical: permanent job errors should fail LDR job #139487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
force-pushed
the
butler-heartbeat-err
branch
from
0dcbaa5 to
d84a3be
Compare
msbutler
requested review from
jeffswenson and
dt
and removed request for
a team
kev-cao
approved these changes
Jan 22, 2025
|
TFTR! bors r=kev-cao |
craig bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
139342: ui: fix statement diag reports when min exec latency is null r=kyle-a-wong a=kyle-a-wong A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. Fixes: #139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable. 139487: crosscluster/logical: permanent job errors should fail LDR job r=kev-cao a=msbutler Previously, permanent job errors would pause the LDR job, like PCR. Since LDR doesn't have a cutover step, we should instead fail the job to provide a clearer UX to the user. Epic: none Release note: none 139491: crosscluster/physical: wait for sip shutdown before cutover r=kev-cao a=msbutler Informs #136588 Release note: none Co-authored-by: Kyle Wong <[email protected]> Co-authored-by: Michael Butler <[email protected]>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
139487: crosscluster/logical: permanent job errors should fail LDR job r=kev-cao a=msbutler Previously, permanent job errors would pause the LDR job, like PCR. Since LDR doesn't have a cutover step, we should instead fail the job to provide a clearer UX to the user. Epic: none Release note: none 139559: rttanalysis: loosen jobs rtts r=dt a=dt Looking at the traces of recent failures of this test, I see 15 batch requests that all look correct to me even though the test says 12. I don't know why it sometimes passes as-is but given that as many as 15 look correct, it should allow for that. Release note: none. Epic: none. Co-authored-by: Michael Butler <[email protected]> Co-authored-by: David Taylor <[email protected]>
|
Build failed (retrying...): |
Previously, permanent job errors would pause the LDR job, like PCR. Since LDR doesn't have a cutover step, we should instead fail the job to provide a clearer UX to the user. Epic: none Release note: none
Fixes cockroachdb#138341 Release note: none
msbutler
force-pushed
the
butler-heartbeat-err
branch
from
d84a3be to
4139bf6
Compare
|
Canceled. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, permanent job errors would pause the LDR job, like PCR. Since LDR
doesn't have a cutover step, we should instead fail the job to provide a
clearer UX to the user.
Epic: none
Release note: none