-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge {marshal,unmarshal}TableValue into marshalValue. #1393
Conversation
This allows easy setting of "typed" values with the standard key/value methods which will be used shortly for setting and retrieving the "descriptor ID" value for namespace keys.
c402ced
to
b70fa1d
Compare
return nil | ||
|
||
case *gogoproto.Message: | ||
panic("TODO(pmattis): unimplemented") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems awkwardish to panic when you could return an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error might be ignored or logged. I wanted something more forceful to as a reminder to implement this support. Should be trivial to do, just haven't done it yet.
LGTM. It's a bit hard to embrace the copious amounts of reflection since we've always tried to avoid it wherever possible, but this being a client library, us having decided to go down this road, and the simplification in this case being significant, this is certainly the right thing to do. |
FWIW, the |
No need to convince me, I'm on your side. |
Merge {marshal,unmarshal}TableValue into marshalValue.
This allows easy setting of "typed" values with the standard key/value
methods which will be used shortly for setting and retrieving the
"descriptor ID" value for namespace keys.