Remove proto.Value.Integer. #1380
Conversation
| row.Value = &t.NewValue | ||
| row.setTimestamp(t.Timestamp) |
There was a problem hiding this comment.
Is this a bug that we don't set the timestamp originally?
There was a problem hiding this comment.
Probably. I don't think anything is using KeyValue.Timestamp right now.
There was a problem hiding this comment.
Ok. See #1383.
|
LGTM |
| @@ -149,7 +149,7 @@ message GetResponse { | |||
|
|
|||
| // A PutRequest is arguments to the Put() method. Note that to write | |||
| // an empty value, the value parameter is still specified, but both | |||
|
\o/ LGTM |
petermattis
force-pushed
the
pmattis/integer-value
branch
from
b1933d4 to
db479ed
Compare
Integer values are now encoded into proto.Value.Bytes and any 0 or 8 byte value can be intepreted as an int64. Some of the printing niceness disappeared from the cockroach cli, but that will hopefully return once we move to the table-based API where we know the types of columns.
petermattis
force-pushed
the
pmattis/integer-value
branch
from
db479ed to
3d52588
Compare
Remove proto.Value.Integer.
| @@ -90,7 +89,14 @@ func (kv *KeyValue) ValueBytes() []byte { | |||
| // ValueInt returns the value as an int64. This method will panic if the | |||
There was a problem hiding this comment.
This method no longer panics.
There was a problem hiding this comment.
It can still panic if the byte slice is less than 8 bytes long. See https://github.com/cockroachdb/cockroach/blob/master/util/encoding/encoding.go#L193.
There was a problem hiding this comment.
Ah, OK, so the interpretation of "value's type" has changed. This is a little unclear since Value is still exposed as an interface{}.
There was a problem hiding this comment.
I'll clean up the comment in a subsequent PR.
Integer values are now encoded into proto.Value.Bytes and any 0 or 8
byte value can be intepreted as an int64. Some of the printing niceness
disappeared from the cockroach cli, but that will hopefully return once
we move to the table-based API where we know the types of columns.