roachtest: opt sysbench out of backup schedule #137930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
There was a problem hiding this comment.
Nice find!
I'll switch this to use the more canonical option.NewStartOpts(option.NoBackupSchedule) and then merge.
Reviewed all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained
nvanbenschoten
force-pushed
the
whoopsie
branch
from
e3d6445 to
1859d76
Compare
nvanbenschoten
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Slack thread1.
Epic: CRDB-42584
Footnotes
https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1734972581281769 ↩