Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvflowcontrol: fix logging redaction for a few types #137699

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Dec 18, 2024

The strings inside SafeFormat() were not marked as safe, and caused the values being printed as redactable.

Part of #136526

@pav-kv pav-kv added the backport-24.3.x Flags PRs that need to be backported to 24.3 label Dec 18, 2024
@pav-kv pav-kv requested review from kvoli and sumeerbhola December 18, 2024 18:32
@pav-kv pav-kv requested a review from a team as a code owner December 18, 2024 18:32
Copy link

blathers-crl bot commented Dec 18, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

The strings inside Tokens.SafeFormat() were not marked as safe, and
caused the value being printed as redactable.

Epic: none
Release note: none
Epic: none
Release note: none
Epic: none
Release note: none
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 2 of 2 files at r4, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @arjunmahishi, @kvoli, and @rafiss)

@pav-kv
Copy link
Collaborator Author

pav-kv commented Dec 19, 2024

TFTRs!

bors r+

@craig craig bot merged commit 95460dd into cockroachdb:master Dec 19, 2024
22 checks passed
Copy link

blathers-crl bot commented Dec 19, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 205fb8e to blathers/backport-release-24.3-137699: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.3.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants