pgwire: rename ReadBuffer.GetString to GetUnsafeString #137682
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Previously, it was not clear that GetString would not copy data from the ReadBuffer. This could be problematic if the object was long lived, since the entire buffer would have been kept alive. To reduce risk, this patch renames GetString to GetUnsafeString. It also adds a GetSafeString method for cases where a copy is needed. The latter is adopted inside: parseClientProvidedSessionParameters Informs: cockroachdb#137627 Release note: None
fqazi
force-pushed
the
sessionMessageLeakCont
branch
from
d2a22ed to
82abfd4
Compare
fqazi
added
backport-24.1.x
There was a problem hiding this comment.
nice, this is will be very helpful for avoiding similar bugs!
Reviewable status:
complete! 0 of 0 LGTMs obtained
|
@rafiss TFTR! bors r+ |
|
bors r- |
|
bors r+ |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.2-137682 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/137769/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-24.1-137682 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/137770/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 24.1.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-24.2-137682 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/137771/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 24.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-24.3-137682 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/137772/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 24.3.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously, it was not clear that GetString would not copy data from the ReadBuffer. This could be problematic if the object was long lived, since the entire buffer would have been kept alive. To reduce risk, this patch renames GetString to GetUnsafeString. It also adds a GetSafeString method for cases where a copy is needed. The latter is adopted inside: parseClientProvidedSessionParameters
Informs: #137627
Release note: None