Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deadmansnitch for code-cover-publish Github Action #137412

Merged
merged 1 commit into from
Dec 13, 2024
Merged

ci: deadmansnitch for code-cover-publish Github Action #137412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/code-cover-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,7 @@ jobs:
parent: false
destination: 'crl-codecover-public/pr-cockroach/'
process_gcloudignore: false

- name: 'Call DeadManSnitch'
run: |
curl -X GET 'https://nosnch.in/c2d75963ee' -d 'message=Code coverage uploaded to GCS'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No auth/API key is needed for this? Wondering if the url should be a secret in that case - although admittedly I haven't looked into how DeadManSnitch works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No auth/API key needed.

About it being a secret, I kinda wondered the same thing, but we already have one publicly available in the repo, and the worst thing that can happen is that something reports the status in lieu of the action (granted that it defeats the purpose...).

Maybe @cockroach-dev-inf has an opinion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't typically have to keep these URL's secret -- the risk isn't huge.

If you want to make this one a secret, be my guest (although you've technically already "leaked" this one, so you should "rotate" it :) )

I'm not aware of any broad issue with third parties hitting these URL's and as mentioned the worst thing that can happen is we think the thing has reported a success when it hasn't.

Loading