Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: deflake TestReplicaCircuitBreaker_RangeFeed #137410

Merged
merged 1 commit into from
Dec 13, 2024
Merged

kvserver: deflake TestReplicaCircuitBreaker_RangeFeed #137410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/kv/kvserver/client_replica_circuit_breaker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ func (cbt *circuitBreakerTest) TripBreaker(idx int) {

func (cbt *circuitBreakerTest) UntripsSoon(t *testing.T, method func(idx int) error, idx int) {
t.Helper()
testutils.SucceedsSoon(t, func() error {
testutils.SucceedsWithin(t, func() error {
t.Helper()
err := method(idx)
// All errors coming out should be annotated as coming from
Expand All @@ -1170,7 +1170,7 @@ func (cbt *circuitBreakerTest) UntripsSoon(t *testing.T, method func(idx int) er
t.Fatalf("saw unexpected error %+v", err)
}
return err
})
}, 2*testutils.SucceedsSoonDuration())
}

func (cbt *circuitBreakerTest) WaitForProposals(t *testing.T, idx int) {
Expand Down
Loading