ci: check that generated documentation is up-to-date #137135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
gen-docs-check
branch
from
cedd44d to
1c5402e
Compare
rickystewart
changed the title
rickystewart
force-pushed
the
gen-docs-check
branch
from
1c5402e to
4689d7d
Compare
jlinder
approved these changes
Dec 11, 2024
Since `release-24.1`, CI has been missing a set of checks that ensure the generated documentation files are configured correctly with respect to `BUILD.bazel` and the checked-in files. Here we add them back in and fix the skew that has already been introduced. Closes: cockroachdb#137133 Epic: none Release note: None
rickystewart
force-pushed
the
gen-docs-check
branch
from
4689d7d to
0b676d9
Compare
|
TFTR! bors r=jlinder |
rickystewart
added
backport-24.1.x
This was referenced Dec 11, 2024
craig bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
137359: changefeedccl/kvfeed: add log for table that encountered schema change r=rharding6373 a=andyyang890 This patch adds a log documenting the table(s) that encountered schema changes and caused the kv feed to restart/exit, which will be useful for debugging. Fixes #136624 Closes #134963 Release note: None 137432: docgen: remove unused BEGIN diagram r=yuzefovich a=taroface #137135 added `begin_stmt` to the .bzl files for SQL diagram generation. However, this diagram is no longer used, and doesn't seem to be generated by `docgen` upon local testing. Removing `begin_stmt` and `begin_stmt.bnf` worked in #137111, so this PR applies the same update to `master` and backports to 24.1-3. (cc `@rickystewart)` Epic: none Release note: None Co-authored-by: Andy Yang <[email protected]> Co-authored-by: Ryan Kuo <[email protected]>
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
release-24.1, CI has been missing a set of checks thatensure the generated documentation files are configured correctly
with respect to
BUILD.bazeland the checked-in files. Here we addthem back in and fix the skew that has already been introduced.
Closes: #137133
Epic: none
Release note: None