crosscluster/logical: create new tables if specified #137089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Epic: none Release: none
This implements the new CREATE LOGICALLY REPLICATES TABLES syntax, which creates the destination tables during LDR planning. In this commit, the tables are created online and LDR iniital scan proceeds as it always has. In a future commit, these tables will be created in an offline state enabling a fast initial scan via AddSStable ingestion. Epic: none Release note: none
msbutler
force-pushed
the
butler-ldr-fast-scan-rebase
branch
from
dd4d612 to
f05cedf
Compare
msbutler
changed the title
msbutler
requested review from
kev-cao and
dt
and removed request for
a team and
kev-cao
msbutler
commented
Dec 10, 2024
| // If the user asked to ignore "ttl-deletes", make sure that at least one of | ||
| // the source tables actually has a TTL job which sets the omit bit that | ||
| // is used for filtering; if not, they probably forgot that step. | ||
| throwNoTTLWithCDCIgnoreError := discard == jobspb.LogicalReplicationDetails_DiscardCDCIgnoredTTLDeletes | ||
|
|
||
| // TODO: consider moving repPair construction into doLDRPlan after dest tables are created. |
There was a problem hiding this comment.
@dt before i do this additional refactor, i'm curious what you think of the patch as it stands now.
dt
approved these changes
Dec 12, 2024
|
TFTR! bors r=dt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new CREATE LOGICALLY REPLICATES TABLES syntax, which
creates the destination tables during LDR planning. In this commit, the tables
are created online and LDR iniital scan proceeds as it always has. In a future
commit, these tables will be created in an offline state enabling a fast
initial scan via AddSStable ingestion.
Epic: none
Release note: none