Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen: update BEGIN and SET TRANSACTION diagrams #137058

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

taroface
Copy link
Collaborator

@taroface taroface commented Dec 9, 2024

Updated the BEGIN diagram, which had been empty since this commit. It now also shows the ISOLATION LEVEL syntax:

image

Also updated SET TRANSACTION with the ISOLATION LEVEL syntax. The diagram had also not been displaying with most of its syntax.

image

Epic: none
Release note: none
Release justification: non-production code change

@taroface taroface added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Dec 9, 2024
@taroface taroface requested review from a team as code owners December 9, 2024 22:41
Copy link

blathers-crl bot commented Dec 9, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks!

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

@taroface
Copy link
Collaborator Author

bors r=yuzefovich

@cockroachdb cockroachdb deleted a comment from craig bot Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants