-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docgen: update BEGIN and SET TRANSACTION diagrams #137058
docgen: update BEGIN and SET TRANSACTION diagrams #137058
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
e2b19a6
to
5cd1392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @michae2)
5cd1392
to
660522e
Compare
bors r=yuzefovich |
Updated the
BEGIN
diagram, which had been empty since this commit. It now also shows theISOLATION LEVEL
syntax:Also updated
SET TRANSACTION
with theISOLATION LEVEL
syntax. The diagram had also not been displaying with most of its syntax.Epic: none
Release note: none
Release justification: non-production code change