-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.3: catalog/descs: avoid log.Fatal for invalid descriptor error #137048
Conversation
Rather tahn crashing the whole process, we can use an assertion error for this. The log.Fatal was initially added in 5d205ed, in a time far before we were careful about avoiding node crashes. Release note: None
649cc8d
to
1c35278
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @spilchen)
Backport 1/1 commits from #136978 on behalf of @rafiss.
/cc @cockroachdb/release
Rather than crashing the whole process, we can use an assertion error for this. The log.Fatal was initially added in 5d205ed, in a time far before we were careful about avoiding node crashes.
fixes #136962
fixes #136961
Release note: None
Release justification: low risk change to error