pkg/util/allstacks: wrap the stack traces with debugutil.SafeStack #137001
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
Get()
andGetWithBuf()
internally callruntime.Stack()
to fetch the calling go routine's stack trace.This commit changes the return type of both the function from
[]byte
todebugutil.SafeStack
(introduced in #136288). This will ensure that the stack traces generated using these function are not redacted.Part of: CRDB-15292
Epic: CRDB-37533
Release note: None