Switch Batch to an implementation of Engine. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of Pete's proposed change to move Batch and Snapshot into C++.
|
@petermattis @cockroachdb/developers |
|
LGTM |
spencerkimball
added a commit
that referenced
this pull request
Oct 20, 2014
Switch Batch to an implementation of Engine.
|
|
||
| // WriteBatch returns an error if called on a Batch. | ||
| func (b *Batch) WriteBatch([]interface{}) error { | ||
| return util.Errorf("cannot report capacity from a Batch") |
There was a problem hiding this comment.
late to the party I know, but this isn't the right error string.
There was a problem hiding this comment.
I made this small change in my most recent changelist.
soniabhishek
pushed a commit
to soniabhishek/cockroach
that referenced
this pull request
Feb 15, 2017
Logic correction for running job managers
pav-kv
pushed a commit
to pav-kv/cockroach
that referenced
this pull request
Mar 5, 2024
testdata: add a lagging commit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of Pete's proposed change to move Batch and
Snapshot into C++.