roachprod: remove cdrb_test for nightly #136281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
herkolategan
force-pushed
the
hbl/roachprod-nightly-no-cdrb-test
branch
from
db6d9c2 to
5d920b3
Compare
srosenberg
approved these changes
Nov 27, 2024
Previously, we included the `--crdb_test` build flag for `roachprod`. This binary is only built to be used as part of the `roachprod update` logic. Adding the flag causes roachprod to produce a log of metamorphic vars which is not expected behaviour when using it as a CLI tool. Informs: cockroachdb#124592 Epic: None Release note: None
herkolategan
force-pushed
the
hbl/roachprod-nightly-no-cdrb-test
branch
from
5d920b3 to
3db6479
Compare
|
TFTR! bors r=srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we included the
--crdb_testbuild flag forroachprod. This binary is only built to be used as part of theroachprod updatelogic. Adding the flag causes roachprod to produce a log of metamorphic vars which is not expected behaviour when using it as a CLI tool.Informs: #124592
Epic: None
Release note: None