Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: add TestFlowControlSendQueueRangeSplitMerge test #136258

Merged

Commits on Dec 10, 2024

  1. kvserver: add TestFlowControlSendQueueRangeSplitMerge test

    Add a new rac2 flow control integration test,
    `TestFlowControlSendQueueRangeSplitMerge`.
    
    This test takes the following steps:
    
    ```sql
    -- We will exhaust the tokens across all streams while admission is blocked on
    -- n3, using a single 4 MiB (deduction, the write itself is small) write. Then,
    -- we will write a 1 MiB put to the range, split it, write a 1 MiB put to the
    -- LHS range, merge the ranges, and write a 1 MiB put to the merged range. We
    -- expect that at each stage where a send queue develops n1->s3, the send queue
    -- will be flushed by the range merge and range split range operations.``sql
    ```
    
    Note that the RHS is not written to post-split, pre-merge. See the
    relevant comments, this will be resolved via cockroachdb#136649, or some variation,
    which enforces the timely replication on subsume requests.
    
    Also note that epoch leases are used in the test, the added todo
    describes why this is currently necessary and an intention to re-enable
    them.
    
    Part of: cockroachdb#132614
    Release note: None
    kvoli committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    202bb43 View commit details
    Browse the repository at this point in the history