sql/catalog: reduce NameKey allocations #136234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Catalog.LookupNamespaceEntry` method now accepts the concrete type `descpb.NameInfo` instead of the `catalog.NameKey` interface. This, along with future commits, will help reduce allocations. Release note: None
The `CatalogReader.IsNameInCache` method now accepts the concrete type `descpb.NameInfo` instead of the `catalog.NameKey` interface. This, along with other commits, will help reduce allocations. Release note: None
The `(*Collection).isShadowedName` method now accepts the concrete type `descpb.NameInfo` instead of the `catalog.NameKey` interface. This, along with other commits, will help reduce allocations. Release note: None
|
This change is |
|
|
rafiss
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @mgartner)
pkg/sql/catalog/internal/catkv/system_database_cache.go line 90 at r4 (raw file):
version clusterversion.ClusterVersion, key descpb.NameInfo, ) (descpb.ID, hlc.Timestamp) { // TODO: Refactor this a bit.
nit: can this comment provide a clue as to what we'd like to refactor?
Now that `(*SystemDatabaseCache).lookupDescriptorID` accepts a `descpb.NameInfo` parameter, it can access its exported field directly instead of using getters. Release note: None
mgartner
force-pushed
the
reduce-namekey-allocs
branch
from
2d6dbb6 to
725bebf
Compare
mgartner
commented
Nov 27, 2024
There was a problem hiding this comment.
Reviewable status:
pkg/sql/catalog/internal/catkv/system_database_cache.go line 90 at r4 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
nit: can this comment provide a clue as to what we'd like to refactor?
Oops, that was a left-over comment. This commit already does the refactoring. Good catch!
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql/catalog: change
LookupNamespaceEntryparameter typeThe
Catalog.LookupNamespaceEntrymethod now accepts the concrete typedescpb.NameInfoinstead of thecatalog.NameKeyinterface. This,along with future commits, will help reduce allocations.
Release note: None
sql/catalog: change
IsNameInCacheparameter typeThe
CatalogReader.IsNameInCachemethod now accepts the concrete typedescpb.NameInfoinstead of thecatalog.NameKeyinterface. This,along with other commits, will help reduce allocations.
Release note: None
sql/catalog: change
(*Collection).isShadowedNameparameter typeThe
(*Collection).isShadowedNamemethod now accepts the concrete typedescpb.NameInfoinstead of thecatalog.NameKeyinterface. This,along with other commits, will help reduce allocations.
Informs #105867
Fixes #135905
Fixes #121300
Release note: None
sql/catalog: refactor
(*SystemDatabaseCache).lookupDescriptorIDNow that
(*SystemDatabaseCache).lookupDescriptorIDaccepts adescpb.NameInfoparameter, it can access its exported field directlyinstead of using getters.
Release note: None