kvserver: bring TestStoreRangeLease to a leader lease world #136229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
iskettaneh
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @arulajmani)
pkg/kv/kvserver/client_lease_test.go line 64 at r1 (raw file):
// we can remove this. Leader leases require us to reject lease requests // on replicas that are not the leader, as otherwise we'll kvserver.RejectLeaseOnLeaderUnknown.Override(ctx, &st.SV, true)
What happens if this was removed?
This patch renames what was previously TestStoreRangeLease by adding a EpochLease suffix to it. Then, we rewrite TestStoreRangeLease to use leader leases instead. References cockroachdb#133763 Release note: None
arulajmani
force-pushed
the
ll-TestStoreRangeLease
branch
from
2a4b6f3 to
28ba34c
Compare
arulajmani
commented
Nov 28, 2024
There was a problem hiding this comment.
Reviewable status:
pkg/kv/kvserver/client_lease_test.go line 64 at r1 (raw file):
Previously, iskettaneh wrote…
What happens if this was removed?
It's not needed. Detritus from trying to stabilize this.
iskettaneh
approved these changes
Nov 28, 2024
|
Thanks! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames what was previously TestStoreRangeLease by adding a EpochLease suffix to it. Then, we rewrite TestStoreRangeLease to use leader leases instead.
References #133763
Release note: None