kvcoord: Disable follower reads for TestProxyTracing

[iskettaneh]

This commit disables follower reads for the test TestProxyTracing. We noticed that sometimes, the test gets slow, and by the time we issue a read request, it's served via follower reads instead of proxying it to the leaseholder.

Fixes: #135493

Release note: None

[cockroach-teamcity]

This change is 

[arulajmani]

Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @iskettaneh)

---

-- commits line 2 at r1:
nit: "disable" -- no caps in the PR title.

---

pkg/kv/kvclient/kvcoord/dist_sender_server_test.go line 4877 at r1 (raw file):

		// Disable follower reads to ensure that the request is proxied, and not
		// answered locally due to follower reads.
		_, err := conn.Exec("SET CLUSTER SETTING kv.closed_timestamp.follower_reads.enabled = false")

Instead of setting the cluster setting like this, we should override it instead (like we're doing for some of the other cluster settings above). Setting it like we are here doesn't wait for cluster settings to be propagated to all nodes (this happens async), so it can lead to a test flake. We therefore prefer the Override method in these test cluster tests instead.

[iskettaneh]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @arulajmani)

---

pkg/kv/kvclient/kvcoord/dist_sender_server_test.go line 4877 at r1 (raw file):

Previously, arulajmani (Arul Ajmani) wrote…

Instead of setting the cluster setting like this, we should override it instead (like we're doing for some of the other cluster settings above). Setting it like we are here doesn't wait for cluster settings to be propagated to all nodes (this happens async), so it can lead to a test flake. We therefore prefer the Override method in these test cluster tests instead.

Done.

[arulajmani]

modulo comment.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)

---

-- commits line 2 at r1:

Previously, arulajmani (Arul Ajmani) wrote…

nit: "disable" -- no caps in the PR title.

Did you mean to fix this?

[iskettaneh]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @iskettaneh)

---

-- commits line 2 at r1:

Previously, arulajmani (Arul Ajmani) wrote…

Did you mean to fix this?

Yes, just changed it into Fixes: #135493

[iskettaneh]

TFTR!

bors r+

[craig]

Build succeeded:

• unit_tests
• docker_image_amd64
• local_roachtest
• linux_amd64_fips_build
• local_roachtest_fips
• macos_amd64_build
• acceptance
• windows_build
• linux_arm64_build
• examples_orms
• lint
• macos_arm64_build
• check_generated_code
• linux_amd64_build

[iskettaneh]

blathers backport 24.1 24.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 1b22141 to blathers/backport-release-24.1-135921: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1 failed. See errors above.

---

error creating merge commit from 1b22141 to blathers/backport-release-24.2-135921: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}