ci: fix private roachtest nightly #135913
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
srosenberg
requested review from
rickystewart and
DarrylWong
and removed request for
a team
|
Confirmed the fix by triggering a run. |
DarrylWong
reviewed
Nov 21, 2024
| set -a | ||
| source "$dir/teamcity-support.sh" | ||
| set +a | ||
|
|
||
| source "$dir/teamcity-support.sh" |
There was a problem hiding this comment.
Is this line still needed?
There was a problem hiding this comment.
Nope 🤦 It was really missing set -a to export root.
DarrylWong
approved these changes
Nov 21, 2024
It appears a change to TC wrapper scripts in [1] may have caused the `root` var. to become unbound. This PR adds the missing `source` statement. [1] cockroachdb#124592 Epic: none Release note: None
srosenberg
force-pushed
the
sr/fix_private_roachtest_ci
branch
from
35e4e31 to
c8bc807
Compare
|
TFTR! bors r=darrylwong |
srosenberg
added
backport-24.3.x
This was referenced Nov 21, 2024
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from c8bc807 to blathers/backport-release-24.1-135913: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears a change to TC wrapper scripts in [1]
may have caused the
rootvar. to become unbound. This PR adds the missingsourcestatement.[1] #124592
Epic: none
Release note: None