roachtest: ignore flaky activerecord tests #135907
Conversation
annrpom
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
i just assigned #135801 to you as well, would you be able to add that test too if it's not too much trouble?
so the full list of tests to ignore:
TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason
TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not
TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update
CockroachDB::AdapterForeignKeyTest#test_foreign_key_violations_are_translated_to_specific_exception_with_validate_false
CockroachDB::AdapterForeignKeyTest#test_foreign_key_violations_on_insert_are_translated_to_specific_exception
CockroachDB::AdapterForeignKeyTest#test_foreign_key_violations_on_delete_are_translated_to_specific_exception
BasicsTest#test_default_values_are_deeply_dupped
| `PostGISTest#test_point_to_json`: "unknown", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update`: "unknown", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason`: "unknown", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not`: "unknown", |
There was a problem hiding this comment.
nit: these new tests are flaky, so should be in the ignoreList.
(right now they are in the blockList, which means the test will expect them to fail every time.)
|
hm, actually the |
annrpom
force-pushed
the
deflake-activerecord
branch
from
e00b052
to
7293fd0
Compare
ok i'll keep my eye out for those! |
| `ActiveRecord::ConnectionAdapters::PostgreSQLAdapterTest#test_translate_no_connection_exception_to_not_established`: "pg_terminate_backend not implemented", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update`: "flaky", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason`: "flaky", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not`: "flaky", |
There was a problem hiding this comment.
can we add BasicsTest#test_default_values_are_deeply_dupped?
There was a problem hiding this comment.
my reading comprehension skills were afoot
Fixes: cockroachdb#134811 Fixes: cockroachdb#135801 Release note: None
annrpom
force-pushed
the
deflake-activerecord
branch
from
7293fd0
to
41d59df
Compare
There was a problem hiding this comment.
lgtm!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nameisbhaskar and @vidit-bhat)
rafiss
added
backport-24.1.x
|
TFTR! ('-')7 ty for adding those backport labels bors r+ |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #134811: branch-release-24.1, branch-release-24.3. Issue #135801: branch-release-24.1, branch-release-24.2, branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes: #134811
Fixes: #135801
Release note: None