Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: match PG error when dropping non-existent trigger #135759

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

yuzefovich
Copy link
Member

Found in pg_regress (which we'll update separately).

Informs: #132515
Epic: None

Release note: None

Found in pg_regress (which we'll update separately).

Release note: None
@yuzefovich yuzefovich requested review from DrewKimball, mw5h and a team November 19, 2024 23:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @mw5h)

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @mw5h)

@yuzefovich
Copy link
Member Author

TFTRs!

bors r+

@craig craig bot merged commit d78b1db into cockroachdb:master Nov 20, 2024
21 of 23 checks passed
@yuzefovich yuzefovich deleted the drop-trigger-error branch November 20, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants