Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.3: roachtest: periodically check if VMs have been preempted #135746

Merged
merged 2 commits into from
Nov 20, 2024
Merged

release-24.3: roachtest: periodically check if VMs have been preempted #135746

merged 2 commits into from
Nov 20, 2024

Conversation

DarrylWong
Copy link
Contributor

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release Justification: Test infra only change

@DarrylWong
roachtest: periodically check if VMs have been preempted
9467f72 
When a VM is preempted, we occasionally observe a test that
does not error out and hangs until it times out. This is wasteful
as the test may not behave as expected but we continue to run the
test, only checking if a VM is preempted until it fails or times out.

This change proactively monitors VMs for any preemptions, cancelling
the test if any preempted VM is found.
@DarrylWong
roachtest: fix TestVMPreemptionPolling data race
1f4456a 
This change switches to pollPreemptionInterval to be a
mutex protected struct instead, as multiple unit tests
modify it and can lead to a data race without.

Fixes: cockroachdb#135267
Epic: none
Release note: none
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 19, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 19, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DarrylWong DarrylWong marked this pull request as ready for review November 19, 2024 22:17
@DarrylWong DarrylWong requested a review from a team as a code owner November 19, 2024 22:17
@DarrylWong DarrylWong requested review from nameisbhaskar and vidit-bhat and removed request for a team November 19, 2024 22:17
@srosenberg srosenberg self-requested a review November 20, 2024 00:21
@DarrylWong DarrylWong merged commit fa8771f into cockroachdb:release-24.3 Nov 20, 2024
20 of 21 checks passed
@DarrylWong DarrylWong mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenberg srosenberg srosenberg approved these changes

@nameisbhaskar nameisbhaskar Awaiting requested review from nameisbhaskar nameisbhaskar is a code owner automatically assigned from cockroachdb/test-eng

@vidit-bhat vidit-bhat Awaiting requested review from vidit-bhat vidit-bhat is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarrylWong @cockroach-teamcity @srosenberg