cloud: use uuid as bucket name #135595
Merged
cloud: use uuid as bucket name #135595
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jeffswenson
force-pushed
the
jeffswenson-randomize-bucket-names
branch
from
80aa5e0 to
b0ce78a
Compare
jeffswenson
changed the title
jeffswenson
requested review from
kev-cao and
msbutler
and removed request for
a team
|
This PR depends on #135619. The roll back and the fix need to be in two different PRs so the fix applies cleanly in all backports. |
jeffswenson
added
backport-23.2.x
msbutler
approved these changes
Nov 18, 2024
Previously, the GCS and S3 tests used hard coded bucket names to test the behavior of buckets that do not exist. Now, the tests use a random UUID. This change is necessary because someone appears to have created the GCP bucket which causes the test to fail. Release Justification: Test Only Change Release Note: None Fixes: cockroachdb#135307 Fixes: cockroachdb#135348 Fixes: cockroachdb#135349 Fixes: cockroachdb#135350 Fixes: cockroachdb#135351 Fixes: cockroachdb#135352
jeffswenson
force-pushed
the
jeffswenson-randomize-bucket-names
branch
from
b0ce78a to
627c9ac
Compare
|
The cloud azure test is failing, but that seems to be independent of this change. |
|
Thanks for the review! |
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the GCS and S3 tests used hard coded bucket names to test
the behavior of buckets that do not exist. Now, the tests use a random
UUID. This change is necessary because someone appears to have created
the GCP bucket which causes the test to fail.
Release Justification: Test Only Change
Release Note: None
Fixes: #135307
Fixes: #135348
Fixes: #135349
Fixes: #135350
Fixes: #135351
Fixes: #135352