roachtest: update regression.diffs #135313
Conversation
mw5h
requested review from
srosenberg and
vidit-bhat
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
We should preserve _version_ markers that were added in #131835.
There was a problem hiding this comment.
Done.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @srosenberg and @vidit-bhat)
| -- check dependency restrictions | ||
| ALTER TABLE main_table DROP COLUMN b; | ||
| -ERROR: cannot drop column b of table main_table because other objects depend on it | ||
| -DETAIL: trigger after_upd_b_row_trig on table main_table depends on column b of table main_table | ||
| -trigger after_upd_a_b_row_trig on table main_table depends on column b of table main_table | ||
| -trigger after_upd_b_stmt_trig on table main_table depends on column b of table main_table | ||
| -HINT: Use DROP ... CASCADE to drop the dependent objects too. | ||
| +ERROR: error executing StatementPhase stage 1 of 1 with 8 MutationType ops: relation "main_table" (649): trigger "after_upd_b_row_trig" contains unknown column "b" |
There was a problem hiding this comment.
Should we extract this error into a separate issue?
There was a problem hiding this comment.
Done. I filed #136918 to track this.
| +ERROR: unimplemented: CREATE TRIGGER | ||
| +HINT: You have attempted to use a feature that is not yet implemented. | ||
| +See: https://go.crdb.dev/issue-v/126359/_version_ | ||
| +ERROR: internal error: building declarative schema change targets for CREATE TRIGGER: runtime error: invalid memory address or nil pointer dereference |
There was a problem hiding this comment.
I think this bug has already been addressed in #135667, but we can update the diff on the next failure.
There was a problem hiding this comment.
Reviewable status:
| -- check dependency restrictions | ||
| ALTER TABLE main_table DROP COLUMN b; | ||
| -ERROR: cannot drop column b of table main_table because other objects depend on it | ||
| -DETAIL: trigger after_upd_b_row_trig on table main_table depends on column b of table main_table | ||
| -trigger after_upd_a_b_row_trig on table main_table depends on column b of table main_table | ||
| -trigger after_upd_b_stmt_trig on table main_table depends on column b of table main_table | ||
| -HINT: Use DROP ... CASCADE to drop the dependent objects too. | ||
| +ERROR: error executing StatementPhase stage 1 of 1 with 8 MutationType ops: relation "main_table" (649): trigger "after_upd_b_row_trig" contains unknown column "b" |
There was a problem hiding this comment.
Done. I filed #136918 to track this.
Updated the regression.diffs file to reflect changes due to improved TRIGGER and collation support. Filed issues for the panic and trigger misbehavior. Fixes: cockroachdb#132515 Informs: cockroachdb#135311 Informs: cockroachdb#135131 Release note: None
|
bors r+ |
Updated the regression.diffs file to reflect changes due to improved TRIGGER and collation support. Filed issues for the panic and trigger misbehavior.
Fixes: #132515
Informs: #135311
Informs: #135131
Release note: None