Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: ccl/sqlproxyccl: throttle logging of all high-frequency errors #135219

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 14, 2024

Backport 1/1 commits from #135008 on behalf of @jaylim-crl.

/cc @cockroachdb/release


In #134613, we introduced rate-limiting for throttler errors, but deferred handling of errors caused by connections blocked by misconfigured access control lists (ACLs). These errors, often due to incorrect CIDR ranges or private endpoints, can lead to excessive retries and logging noise.

This commit addresses that issue by introducing a new log-limiting mechanism for high-frequency errors based on an (IP, tenant) pair. The following cases are now covered:

  1. Refused connections (ACL misconfigurations) - excessive retries from disallowed IPs or private endpoint IDs.
  2. Auth throttling (invalid logins) - throttling errors due to invalid login attempts.
  3. Deleted/invalid cluster - errors when a deleted tenant still receives request.

This change is internal, so no release note is required.

Epic: none

Release note: None


Release justification: This update is an internal change aimed at optimizing the logging process for the sqlproxy component. CockroachDB Cloud requires this patch to reduce the volume of logs being sent to our logging pipeline.

In #134613, we introduced rate-limiting for throttler errors, but deferred
handling of errors caused by connections blocked by misconfigured access
control lists (ACLs). These errors, often due to incorrect CIDR ranges or
private endpoints, can lead to excessive retries and logging noise.

This commit addresses that issue by introducing a new log-limiting mechanism
for high-frequency errors based on an (IP, tenant) pair. The following cases
are now covered:

1. Refused connections (ACL misconfigurations) - excessive retries from
   disallowed IPs or private endpoint IDs.
2. Auth throttling (invalid logins) - throttling errors due to invalid login
   attempts.
3. Deleted/invalid cluster - errors when a deleted tenant still receives
   request.

This change is internal, so no release note is required.

Epic: none

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-135008 branch from 2792530 to 4f3e0cc Compare November 14, 2024 21:31
@blathers-crl blathers-crl bot requested review from a team as code owners November 14, 2024 21:31
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 14, 2024
Copy link
Author

blathers-crl bot commented Nov 14, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 14, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@DuskEagle DuskEagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLProxy changes are safe to backport in general.

@jaylim-crl jaylim-crl merged commit 4db7acb into release-24.2 Nov 18, 2024
19 of 20 checks passed
@jaylim-crl jaylim-crl deleted the blathers/backport-release-24.2-135008 branch November 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants