-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.2: ccl/sqlproxyccl: throttle logging of all high-frequency errors #135219
Merged
jaylim-crl
merged 1 commit into
release-24.2
from
blathers/backport-release-24.2-135008
Nov 18, 2024
Merged
release-24.2: ccl/sqlproxyccl: throttle logging of all high-frequency errors #135219
jaylim-crl
merged 1 commit into
release-24.2
from
blathers/backport-release-24.2-135008
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #134613, we introduced rate-limiting for throttler errors, but deferred handling of errors caused by connections blocked by misconfigured access control lists (ACLs). These errors, often due to incorrect CIDR ranges or private endpoints, can lead to excessive retries and logging noise. This commit addresses that issue by introducing a new log-limiting mechanism for high-frequency errors based on an (IP, tenant) pair. The following cases are now covered: 1. Refused connections (ACL misconfigurations) - excessive retries from disallowed IPs or private endpoint IDs. 2. Auth throttling (invalid logins) - throttling errors due to invalid login attempts. 3. Deleted/invalid cluster - errors when a deleted tenant still receives request. This change is internal, so no release note is required. Epic: none Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.2-135008
branch
from
November 14, 2024 21:31
2792530
to
4f3e0cc
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Nov 14, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Nov 14, 2024
DuskEagle
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQLProxy changes are safe to backport in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #135008 on behalf of @jaylim-crl.
/cc @cockroachdb/release
In #134613, we introduced rate-limiting for throttler errors, but deferred handling of errors caused by connections blocked by misconfigured access control lists (ACLs). These errors, often due to incorrect CIDR ranges or private endpoints, can lead to excessive retries and logging noise.
This commit addresses that issue by introducing a new log-limiting mechanism for high-frequency errors based on an (IP, tenant) pair. The following cases are now covered:
This change is internal, so no release note is required.
Epic: none
Release note: None
Release justification: This update is an internal change aimed at optimizing the logging process for the sqlproxy component. CockroachDB Cloud requires this patch to reduce the volume of logs being sent to our logging pipeline.