Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: pgwire,authccl: use pgx for TestAuthenticationAndHBARules #135178

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 14, 2024

Backport 2/2 commits from #135086.

/cc @cockroachdb/release

Release justification: test only change


The lib/pq driver is not maintained. Since we started to see flakes related to how that driver does error handling for secure connections, we switch to pgx instead.

fixes #127745
fixes #131532
fixes #131110
fixes #133360

Release note: None

@rafiss rafiss requested a review from souravcrl November 14, 2024 16:04
@rafiss rafiss requested review from a team as code owners November 14, 2024 16:04
Copy link

blathers-crl bot commented Nov 14, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 14, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss removed request for a team November 14, 2024 16:04
The lib/pq driver is not maintained. Since we started to see flakes
related to how that driver does error handling for secure connections,
we switch to pgx instead.

Release note: None
@rafiss rafiss force-pushed the backport23.1-135086 branch from 0613f58 to e5e3d61 Compare November 14, 2024 16:17
@rafiss rafiss force-pushed the backport23.1-135086 branch from e5e3d61 to 07eba36 Compare November 14, 2024 17:02
@rafiss rafiss merged commit db458f9 into cockroachdb:release-23.1 Nov 14, 2024
5 of 6 checks passed
@rafiss rafiss deleted the backport23.1-135086 branch November 14, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants