Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: fixes to BenchmarkFlowControlV2Basic #135121

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sumeerbhola
Copy link
Collaborator

Fixed a bug that was using incorrect number of iterations. And made the benchmark more stable, and useful for smaller number of iterations, by using OverrideTokenDeduction to deduct 1MiB of tokens for tiny writes.

Informs #128033

Epic: CRDB-37515

Release note: None

Fixed a bug that was using incorrect number of iterations. And made the
benchmark more stable, and useful for smaller number of iterations, by
using OverrideTokenDeduction to deduct 1MiB of tokens for tiny writes.

Informs cockroachdb#128033

Epic: CRDB-37515

Release note: None
@sumeerbhola sumeerbhola requested a review from kvoli November 13, 2024 22:32
@sumeerbhola sumeerbhola requested a review from a team as a code owner November 13, 2024 22:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@kvoli kvoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

@sumeerbhola
Copy link
Collaborator Author

TFTR!

@sumeerbhola
Copy link
Collaborator Author

bors r=kvoli

@craig craig bot merged commit f0da223 into cockroachdb:master Nov 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants