Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.1: sql: Drop Role does not properly check if target user does not exist #134968

Merged
merged 2 commits into from
Nov 12, 2024
Merged

release-24.1: sql: Drop Role does not properly check if target user does not exist #134968

merged 2 commits into from
Nov 12, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 12, 2024 •
edited by rafiss
Loading

Backport 1/1 commits from #134850 on behalf of @Dedej-Bergin.

/cc @cockroachdb/release

Previously when we are a non-admin user and we run drop role if exists on a user that does not exist we would get an error that the user does not exist. This is incosistent with other if exists commands and it does not make sense to get an error since by typing if exists we expect that the user may not exist. These code changes take care of that.

Loom Video Description: https://www.loom.com/share/cd75d692ef3940be9b3fd395dc911f71?sid=ad6b27e1-620f-45b1-be10-9b733408fae5

Fixes: #134538

Release note (bug fix): When you are a non-admin user and you run drop role if exists on a user that does not exist you no longer get an error message.

Release justification: low risk bug fix

@Dedej-Bergin
sql: Drop Role does not properly check if target user does not exist
1eae815 
Previously when we are a non-admin user and we run drop role if exists
on a user that does not exist we would get an error that the user does
not exist.  This is incosistent with other if exists commands and it
does not make sense to get an error since by typing if exists we expect
that the user may not exist.  These code changes take care of that.

Fixes: #134538

Release note (bug fix): When you are a non-admin user and you run drop
role if exists on a user that does not exist you no longer get an error
message.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-134850 branch from 104b889 to 1eae815 Compare November 12, 2024 15:29
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 12, 2024 15:29
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 12, 2024
@blathers-crl blathers-crl bot requested a review from spilchen November 12, 2024 15:29
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Nov 12, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 12, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
sql: avoid role existence check in DROP ROLE when it's not necessary
8254308 
We only need to make the RoleExists call when the `IF EXISTS` clause is
used.

This check was recently added in 696869a.

Release note: None
@rafiss rafiss mentioned this pull request Nov 12, 2024
Merged
@Dedej-Bergin Dedej-Bergin merged commit 28a58d5 into release-24.1 Nov 12, 2024
19 of 20 checks passed
@Dedej-Bergin Dedej-Bergin deleted the blathers/backport-release-24.1-134850 branch November 12, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@spilchen spilchen Awaiting requested review from spilchen

Assignees

@Dedej-Bergin Dedej-Bergin

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @Dedej-Bergin