tablemetadatacache,ui: change error messaging for failed tmj update #134902
Conversation
|
This change is |
There was a problem hiding this comment.
one small request, looks good otherwise
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @dhartunian, @kyle-a-wong, and @xinhaoz)
-- commits line 4 at r1:
spelling: metaddata
pkg/sql/tablemetadatacache/table_metadata_batch_iterator.go line 206 at r1 (raw file):
if len(res.Errors) > 0 { // For now, we won't write partial results to the cache.
Can we log the errors, so if something is failing repeatedly we could see the actual error message?
eg:
for err := range res.Errors {
log.Error(ctx, err)
}
kyle-a-wong
force-pushed
the
tmj_error_tooltip
branch
from
5df7efd to
10c116d
Compare
Previously, error messages from the table metadata update job were surfaced in the UI on the table overview page. These errors are usually overly verbose and don't provide any actionable info to the end user. In addition to this, error messages can be very big if the error is a result of a span stats fanout failure, which can contain errors for each fanned out request. Now, db-console will simply report that an error occured in the job and that the data is stale. The error returned from failed SpanStats requests will now have a generic "An error has occurred while fetching span stats." Epic: None Release note: None
kyle-a-wong
force-pushed
the
tmj_error_tooltip
branch
from
10c116d to
f496738
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/tablemetadatacache/table_metadata_batch_iterator.go line 206 at r1 (raw file):
Previously, angles-n-daemons (Brian Dillmann) wrote…
Can we log the errors, so if something is failing repeatedly we could see the actual error message?
eg:
for err := range res.Errors { log.Error(ctx, err) }
Done
There was a problem hiding this comment.
Reviewable status:
Previously, angles-n-daemons (Brian Dillmann) wrote…
spelling: metaddata
done
There was a problem hiding this comment.
Reviewable status:
|
tftr! bors r+ |
Previously, error messages from the table metaddata update job were surfaced in the UI on the table overview page. These errors are usually overly verbose and don't provide any actionable info to the end user.
In addition to this, error messages can be very big if the error is a result of a span stats fanout failure, which can contain errors for each fanned out request.
Now, db-console will simply report that an error occured in the job and that the data is stale. The error returned from failed SpanStats requests will now have a generic "An error has occurred while fetching span stats."
Epic: None
Release note: None
Old error messaging:
New error messaging:
