-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
license: unredact logs written by license enforcer #134875
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your CI failures look related to the SafeValue
change for LicType
. Do we need to update the allowlist in redactcheck.go
?
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
a88d51f
to
0a46846
Compare
ah yeah, that's correct. i always forget about that redactcheck linter |
This makes it so log messages are not redacted unnecessarily. - Use redact.StringBuilder instead of strings.Builder. - Avoid using `.String()` arguments for log.Infof, since strings are always redacted. - Mark license type as a redact.SafeValue. Release note: None
0a46846
to
255f10f
Compare
tftr! bors r+ |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 255f10f to blathers/backport-release-23.1-134875: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This makes it so log messages are not redacted unnecessarily.
.String()
arguments for log.Infof, since strings are always redacted.Epic: None
Release note: None