storage: ingest columnar-block sstables when enabled #134671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
force-pushed
the
ingest-colblks
branch
from
797bc01 to
bfa3922
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
RaduBerinde
approved these changes
Nov 8, 2024
jbowens
force-pushed
the
ingest-colblks
branch
5 times, most recently
from
bfd1ad3 to
0c6424d
Compare
jbowens
force-pushed
the
ingest-colblks
branch
2 times, most recently
from
4a85b2e to
bf07a6b
Compare
When the active cluster verison is sufficiently high and the columnar blocks cluster setting is enabled, build sstables for ingestion in table format TableFormatPebblev5 with columnar blocks. Epic: none Release note: none
jbowens
force-pushed
the
ingest-colblks
branch
from
bf07a6b to
fa505ac
Compare
jbowens
commented
Nov 14, 2024
There was a problem hiding this comment.
@RaduBerinde I made some minor tweaks to fix up the remaining tests, if you want to give it another look, otherwise I'll merge away in a few days (want to avoid adding fuel to the fire on master with this replica inconsistency investigation ongoing)
Reviewable status:
complete! 0 of 0 LGTMs obtained
RaduBerinde
reviewed
Nov 14, 2024
|
TFTR! bors r=RaduBerinde |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
RaduBerinde
approved these changes
Nov 19, 2024
|
poked the cla status bors r=RaduBerinde |
|
Already running a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the active cluster verison is sufficiently high and the columnar blocks cluster setting is enabled, build sstables for ingestion in table format TableFormatPebblev5 with columnar blocks.
Epic: none
Release note: none