Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: don't redact job ID in log tags; don't redact internal executor opName #134347

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 5, 2024

This will assist with debugging.

fixes #132113
Release note: None

This will assist with debugging.

Release note: None
@rafiss rafiss added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Nov 5, 2024
@rafiss rafiss requested review from fqazi and a team November 5, 2024 22:12
@rafiss rafiss requested review from a team as code owners November 5, 2024 22:12
@rafiss rafiss requested review from azhu-crl and removed request for a team November 5, 2024 22:12
Copy link

blathers-crl bot commented Nov 5, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from a team as a code owner November 5, 2024 22:17
@rafiss rafiss requested review from xinhaoz and removed request for a team November 5, 2024 22:17
@rafiss rafiss requested review from a team as code owners November 5, 2024 22:44
@rafiss rafiss requested review from herkolategan and DarrylWong and removed request for a team, azhu-crl and xinhaoz November 5, 2024 22:44
@rafiss rafiss force-pushed the unredact-job-and-intExec branch 2 times, most recently from 9a42d92 to c7de630 Compare November 6, 2024 17:12
@rafiss rafiss requested a review from a team as a code owner November 6, 2024 17:12
@rafiss rafiss force-pushed the unredact-job-and-intExec branch 3 times, most recently from a168df5 to e5eeb41 Compare November 6, 2024 17:58
This will make it so we can see the unredacted operation name, which
will assist with dbeugging.

Release note: None
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rafiss
Copy link
Collaborator Author

rafiss commented Nov 7, 2024

bors r+

@craig craig bot merged commit f77bcd0 into cockroachdb:master Nov 7, 2024
23 checks passed
Copy link

blathers-crl bot commented Nov 7, 2024

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #132113: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link

blathers-crl bot commented Nov 7, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7b7e6c5 to blathers/backport-release-23.2-134347: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


error creating merge commit from 7b7e6c5 to blathers/backport-release-24.1-134347: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rafiss rafiss removed backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. labels Nov 7, 2024
@rafiss rafiss deleted the unredact-job-and-intExec branch November 9, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schemachanger: log unredacted job ID in scbuild/scrun messages
3 participants