Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix bad restore paths in roachtests #134215

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

kev-cao
Copy link
Contributor

@kev-cao kev-cao commented Nov 4, 2024

Changes introduced in #133296 updated restore syntax to the FROM/IN syntax, but as the restores were from backups made using the old BACKUP TO syntax, the restore paths are incorrect. This updates the paths to match the backup directories.

Fixes: #133791

Epic: none

Release note: none

Changes introduced in cockroachdb#133296 updated restore syntax to the FROM/IN
syntax, but as the restores were from backups made using the old BACKUP
TO syntax, the restore paths are incorrect. This updates the paths to
match the backup directories.

Fixes: cockroachdb#133791

Epic: none

Release note: none
@kev-cao kev-cao requested review from dt and yuzefovich November 4, 2024 16:48
@kev-cao kev-cao requested a review from a team as a code owner November 4, 2024 16:48
@kev-cao kev-cao requested review from herkolategan and DarrylWong and removed request for a team November 4, 2024 16:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I trust you that this works 😃 :lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @dt, and @herkolategan)

@kev-cao
Copy link
Contributor Author

kev-cao commented Nov 4, 2024

TFTR!

bors r=yuzefovich

@craig craig bot merged commit cb4cc3a into cockroachdb:master Nov 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: tpcdsvec failed [backup not found]
3 participants