release-23.1: settings: redact all string settings for diagnostics #134063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #133754.
/cc @cockroachdb/release
Previously, the redaction logic for
Sensitive
settings in the diagnotics payload was conditional on the value of the"server.redact_sensitive_settings.enabled"
cluster setting.This commit modifies the behavior of
RedactedValue
used to render modified cluster settings by thediagnostics
package to always fully redact the values of string settings and any sensitive or non- reportable settings.Because the
MaskedSetting
struct is now in use by code in theSHOW CLUSTER SETTING
code path, we no longer rely on it for redaction behavior of string settings.Resolves: CRDB-43457
Epic: None
Release note (security update): all cluster settings that accept strings are now fully redacted when transmitted as part of our diagnostics telemetry. This payload includes a record of modified cluster settings and their values when they are not strings. Customers who previously applied the mitigations in Technical Advisory 133479 can safely set the value of cluster setting
server.redact_sensitive_settings.enabled
to false and turn on diagnostic reporting via thediagnostics.reporting.enabled
cluster setting without leaking sensitive cluster settings values.Note: "sensitive" settings were introduced in 23.2 so this backport will affect non-reportable and string settings for 23.1
Release justification: removing sensitive data from diagnostics output.