sql: support COLLATE expressions on arrays #133751
Conversation
|
This change is |
michae2
force-pushed
the
collated
branch
2 times, most recently
from
4ec8e74 to
ba2b61f
Compare
|
This came up during an escalation a couple weeks ago. It probably needs a few more tests, but should be RFAL. |
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @mw5h)
pkg/sql/logictest/testdata/logic_test/collatedstring line 616 at r1 (raw file):
subtest collate_array # Test collation of string arrays.
Can you add some nested array test cases, e..g, SELECT '{{a}}'::TEXT[][] COLLATE "...";.
There was a problem hiding this comment.
Thanks!
Reviewable status:
pkg/sql/logictest/testdata/logic_test/collatedstring line 616 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
Can you add some nested array test cases, e..g,
SELECT '{{a}}'::TEXT[][] COLLATE "...";.
This is a little tricky because of #32552. I did add a few, but the results don't exactly match PG due to #36815.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
In PG, COLLATE is a scalar operator that modifies its operand to produce a collated type. This commit adds support for COLLATE on arrays of strings, which marks them as arrays of collated strings. Epic: None Release note (sql change): Add support for COLLATE expressions on arrays of strings, to better match PostgreSQL.
|
TFTR! bors r=mgartner |
133751: sql: support COLLATE expressions on arrays r=mgartner a=michae2 In PG, COLLATE is a scalar operator that modifies its operand to produce a collated type. This commit adds support for COLLATE on arrays of strings, which marks them as arrays of collated strings. Epic: None Release note (sql change): Add support for COLLATE expressions on arrays of strings, to better match PostgreSQL. 136173: workload: handle timestamp native type in CSV writer and a benchmark r=yuzefovich a=yuzefovich In ef3946c we forgot to update two spots to handle the native timestamp type in the CSV writer and a benchmark. Fixes: #135975. Fixes: #135979. Fixes: #135984. Release note: None Co-authored-by: Michael Erickson <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
|
looks like this was cancelled, trying again bors r=mgartner |
In PG, COLLATE is a scalar operator that modifies its operand to produce a collated type. This commit adds support for COLLATE on arrays of strings, which marks them as arrays of collated strings.
Epic: None
Release note (sql change): Add support for COLLATE expressions on arrays of strings, to better match PostgreSQL.