Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: opt: fix bugs in plan gist decoding #133727

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 29, 2024

Backport 2/2 commits from #109627 on behalf of @mgartner.

/cc @cockroachdb/release


opt: fix plan gist decoding of inverted filters

Details about inverted filter nodes are not encoded in plan gists. The
plan gist decoder incorrectly assumed there were some details encoded,
and would raise an internal error whenever decoding a plan gist with an
inverted filter. This commit fixes the incorrect assumption to prevent
the internal error.

Fixes #108979

There is no release not because plan gists are an undocumented feature.

Release note: None

opt: fix plan gist decoding internal error

This commit fixes some cases where crdb_internal.decode_plan_gist
could raise internal index-out-of-bound errors when given incorrectly
formed input.

Fixes #109560

Release note: None


Release justification: Low-risk bug fix.

Details about inverted filter nodes are not encoded in plan gists. The
explain emitter assumed there were always some details encoded, and
would raise an internal error whenever decoding a plan gist with an
inverted filter. This commit prevents the internal error from occurring.

Fixes #108979

There is no release not because plan gists are an undocumented feature.

Release note: None
This commit fixes some cases where `crdb_internal.decode_plan_gist`
could raise internal index-out-of-bound errors when given incorrectly
formed input.

Fixes #109560

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 29, 2024 19:34
@blathers-crl blathers-crl bot requested review from DrewKimball and removed request for a team October 29, 2024 19:34
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-109627 branch from 7107e84 to e91b8f1 Compare October 29, 2024 19:34
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 29, 2024
Copy link
Author

blathers-crl bot commented Oct 29, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from mgartner October 29, 2024 19:34
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 29, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner
Copy link
Collaborator

This backport is motivated by #133645.

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner merged commit a8b1e9d into release-23.1 Oct 30, 2024
6 checks passed
@mgartner mgartner deleted the blathers/backport-release-23.1-109627 branch October 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants