-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: opt: fix bugs in plan gist decoding #133727
Conversation
Details about inverted filter nodes are not encoded in plan gists. The explain emitter assumed there were always some details encoded, and would raise an internal error whenever decoding a plan gist with an inverted filter. This commit prevents the internal error from occurring. Fixes #108979 There is no release not because plan gists are an undocumented feature. Release note: None
This commit fixes some cases where `crdb_internal.decode_plan_gist` could raise internal index-out-of-bound errors when given incorrectly formed input. Fixes #109560 Release note: None
7107e84
to
e91b8f1
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
This backport is motivated by #133645. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Backport 2/2 commits from #109627 on behalf of @mgartner.
/cc @cockroachdb/release
opt: fix plan gist decoding of inverted filters
Details about inverted filter nodes are not encoded in plan gists. The
plan gist decoder incorrectly assumed there were some details encoded,
and would raise an internal error whenever decoding a plan gist with an
inverted filter. This commit fixes the incorrect assumption to prevent
the internal error.
Fixes #108979
There is no release not because plan gists are an undocumented feature.
Release note: None
opt: fix plan gist decoding internal error
This commit fixes some cases where
crdb_internal.decode_plan_gist
could raise internal index-out-of-bound errors when given incorrectly
formed input.
Fixes #109560
Release note: None
Release justification: Low-risk bug fix.