raft: enable store liveness in raft unit tests phase 1 #133670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
arulajmani
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)
iskettaneh
force-pushed
the
RaftEnableStoreLivenessTests
branch
from
a5dc86e to
1ca7833
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
133131: workload/schemachange: setColumnType operations will occasionally fail r=Dedej-Bergin a=Dedej-Bergin Previously this test would fail due to 0A000 and 2BP01 even though those failures are expected. In these code changes we properly handle these errors. Epic: CRDB-25314 Fixes: #66662 Release note: None 133670: raft: enable store liveness in raft unit tests phase 1 r=iskettaneh a=iskettaneh This commit modifies the following tests to allow them to run in both store liveness enabled/disabled configurations: 1) TestCommitWithoutNewTermEntry 2) TestConfChangeCheckBeforeCampaign 3) TestConfChangeV2CheckBeforeCampaign 4) TestLeaderCycle 5) TestLeaderCyclePreVote 6) TestLeaderTransferReceiveHigherTermVote 7) TestLogReplication 8) TestOldMessages References: #132241 Release note: None Co-authored-by: Bergin Dedej <[email protected]> Co-authored-by: Ibrahim Kettaneh <[email protected]>
|
Build failed (retrying...): |
|
bors r- Some issue with the CI job that I've never seen before... |
|
Canceled. |
iskettaneh
force-pushed
the
RaftEnableStoreLivenessTests
branch
from
1ca7833 to
79de58f
Compare
This commit modifies the following tests to allow them to run in both store liveness enabled/disabled configurations: 1) TestCommitWithoutNewTermEntry 2) TestConfChangeCheckBeforeCampaign 3) TestConfChangeV2CheckBeforeCampaign 4) TestLeaderCycle 5) TestLeaderCyclePreVote 6) TestLeaderTransferReceiveHigherTermVote 7) TestLogReplication 8) TestOldMessages References: cockroachdb#132241 Release note: None
iskettaneh
force-pushed
the
RaftEnableStoreLivenessTests
branch
from
79de58f to
4e5b2d9
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the following tests to allow them to run in both store liveness enabled/disabled configurations:
References: #132241
Release note: None