kv: fix assertion in TestProxyTracing #133609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the assertion in TestProxyTracing so that the test will fail if request proxying is not working as expected. The test was fooling itself, expecting QueryRowContext to return a nil Row if no matching trace event was found. This is not the case, as a nil Row is never returned. Instead, Row.Scan returns ErrNoRows if no matching row is found. Also, the query wasn't even running because it was passing the last line of the query string in as a parameter, leading to the error: "pq: got 1 parameters but the statement requires 0". I confirmed that before this change, the test passes even with request proxying disabled. After this change, the test fails. Epic: None Release note: None
nvanbenschoten
added
backport-24.1.x
|
This change is |
kvoli
approved these changes
Oct 28, 2024
|
TFTR!
I was trying to add leader leases to the test to demonstrate that we've recently fixed request proxying with them and found that the test passed even without the fix. bors r+ |
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the assertion in
TestProxyTracingso that the test will fail if request proxying is not working as expected. The test was fooling itself, expectingQueryRowContextto return a nilRowif no matching trace event was found. This is not the case, as a nilRowis never returned. Instead,Row.ScanreturnsErrNoRowsif no matching row is found.Also, the query wasn't even running because it was passing the last line of the query string in as a parameter, leading to the error:
"pq: got 1 parameters but the statement requires 0".I confirmed that before this change, the test passes even with request proxying disabled. After this change, the test fails.
Epic: None
Release note: None