-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drtprod: increase drt-scale warehouses and reduce RF to 3 #133553
Merged
craig
merged 1 commit into
cockroachdb:master
from
vidit-bhat:drtprod-increase-wh-reduce-rf
Oct 29, 2024
Merged
drtprod: increase drt-scale warehouses and reduce RF to 3 #133553
craig
merged 1 commit into
cockroachdb:master
from
vidit-bhat:drtprod-increase-wh-reduce-rf
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidit-bhat
requested review from
nameisbhaskar,
DarrylWong and
shailendra-patel
and removed request for
a team
October 28, 2024 09:58
vidit-bhat
force-pushed
the
drtprod-increase-wh-reduce-rf
branch
from
October 28, 2024 10:20
172e887
to
c0bedfd
Compare
vidit-bhat
force-pushed
the
drtprod-increase-wh-reduce-rf
branch
4 times, most recently
from
October 28, 2024 10:34
5ee7256
to
eb4bf55
Compare
This PR increases the primary and secondary tpcc warehouses to 400k and 2M respectively. We also reduced the RF to 3 and removed some unnecessary steps. Epic: none Release note: None
vidit-bhat
force-pushed
the
drtprod-increase-wh-reduce-rf
branch
from
October 28, 2024 10:35
eb4bf55
to
1d70722
Compare
nameisbhaskar
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tested out the changes. TFTR! |
craig bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
133553: drtprod: increase drt-scale warehouses and reduce RF to 3 r=nameisbhaskar a=vidit-bhat This PR increases the primary and secondary `tpcc` warehouses to 400k and 2M respectively. We also reduced the RF to 3 and removed some unnecessary steps. Epic: none Release note: None Co-authored-by: Vidit Bhat <[email protected]>
Build failed: |
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the primary and secondary
tpcc
warehouses to 400k and 2M respectively. We also reduced the RF to 3 and removed some unnecessary steps.Epic: none
Release note: None