Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drtprod: increase drt-scale warehouses and reduce RF to 3 #133553

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

vidit-bhat
Copy link
Contributor

This PR increases the primary and secondary tpcc warehouses to 400k and 2M respectively. We also reduced the RF to 3 and removed some unnecessary steps.

Epic: none
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@vidit-bhat vidit-bhat marked this pull request as ready for review October 28, 2024 09:58
@vidit-bhat vidit-bhat requested a review from a team as a code owner October 28, 2024 09:58
@vidit-bhat vidit-bhat requested review from nameisbhaskar, DarrylWong and shailendra-patel and removed request for a team October 28, 2024 09:58
@vidit-bhat vidit-bhat marked this pull request as draft October 28, 2024 10:06
@vidit-bhat vidit-bhat force-pushed the drtprod-increase-wh-reduce-rf branch from 172e887 to c0bedfd Compare October 28, 2024 10:20
@vidit-bhat vidit-bhat marked this pull request as ready for review October 28, 2024 10:20
@vidit-bhat vidit-bhat force-pushed the drtprod-increase-wh-reduce-rf branch 4 times, most recently from 5ee7256 to eb4bf55 Compare October 28, 2024 10:34
This PR increases the primary and secondary tpcc warehouses
to 400k and 2M respectively. We also reduced the RF to 3 and
removed some unnecessary steps.

Epic: none
Release note: None
@vidit-bhat vidit-bhat force-pushed the drtprod-increase-wh-reduce-rf branch from eb4bf55 to 1d70722 Compare October 28, 2024 10:35
Copy link
Contributor

@nameisbhaskar nameisbhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vidit-bhat
Copy link
Contributor Author

Tested out the changes. TFTR!
bors r=nameisbhaskar

craig bot pushed a commit that referenced this pull request Oct 29, 2024
133553: drtprod: increase drt-scale warehouses and reduce RF to 3 r=nameisbhaskar a=vidit-bhat

This PR increases the primary and secondary `tpcc` warehouses to 400k and 2M respectively. We also reduced the RF to 3 and removed some unnecessary steps.

Epic: none
Release note: None

Co-authored-by: Vidit Bhat <[email protected]>
@craig
Copy link
Contributor

craig bot commented Oct 29, 2024

Build failed:

@vidit-bhat
Copy link
Contributor Author

bors retry

@craig craig bot merged commit 987dd38 into cockroachdb:master Oct 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants