Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drtprod: modify tpch run script. #133532

Merged
merged 1 commit into from
Oct 28, 2024
Merged

drtprod: modify tpch run script. #133532

merged 1 commit into from
Oct 28, 2024

Conversation

shailendra-patel
Copy link
Contributor

Modifying tpch run script to fix the number of arguments.

Epic: none

Release note: None

@shailendra-patel
drtprod: modify tpch run script.
26a7365 
Modifying tpch run script to fix the number of arguments.

Epic: none

Release note: None
@shailendra-patel shailendra-patel marked this pull request as ready for review October 28, 2024 06:40
@shailendra-patel shailendra-patel requested a review from a team as a code owner October 28, 2024 06:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@shailendra-patel shailendra-patel requested review from nameisbhaskar and vidit-bhat and removed request for a team October 28, 2024 06:40
vidit-bhat
vidit-bhat approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@vidit-bhat vidit-bhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nameisbhaskar
nameisbhaskar approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@nameisbhaskar nameisbhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shailendra-patel
Copy link
Contributor Author

TFTR!
bors r = vidit-bhat,nameisbhaskar

@shailendra-patel
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 28, 2024

Build succeeded:

@craig craig bot merged commit 769a47f into cockroachdb:master Oct 28, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidit-bhat vidit-bhat vidit-bhat approved these changes

@nameisbhaskar nameisbhaskar nameisbhaskar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shailendra-patel @cockroach-teamcity @nameisbhaskar @vidit-bhat