-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.3: kvserver: preinitialize some Pebble category stats #133521
release-24.3: kvserver: preinitialize some Pebble category stats #133521
Conversation
4a34f89
to
cc5bb0d
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
TFTR! |
Backport 1/1 commits from #133508 on behalf of @RaduBerinde.
/cc @cockroachdb/release
Release justification: needed to unblock bumping Pebble dep (which has more fixes for 24.3).
This change fixes non-determinism when generating
metrics.html
dueto the Pebble category stats.
Informs #133507
Unblocks #133409
Epic: none
Release note: None
Release justification: