Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: sqlccl: deflake TestExplainGist when run with concurrent ALTER PK #133342

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 24, 2024

Backport 1/1 commits from #133130 on behalf of @spilchen.

/cc @cockroachdb/release


TestExplainGist occasionally fails when a query using a secondary index tries to fetch a column not included in that index (see issue #130282). This change doesn’t address the root cause, but instead ignores the error when it occurs. I've also created a more reliable reproducer in the TestDMLInjectionTest, which we can use to validate the eventual fix (#133129).

Epic: none
Closes #130282
Release note: none


Release justification:

TestExplainGist occasionally fails when a query using a secondary index
tries to fetch a column not included in that index (see issue #130282).
This change doesn’t address the root cause, but instead ignores the
error when it occurs. I've also created a more reliable reproducer in
the TestDMLInjectionTest, which we can use to validate the eventual fix
(#133129).

Epic: none
Closes #130282
Release note: none
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 24, 2024 10:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-133130 branch from 05f8879 to e656f0d Compare October 24, 2024 10:48
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 24, 2024 10:48
@blathers-crl blathers-crl bot requested review from rytaft and removed request for a team October 24, 2024 10:48
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 24, 2024
Copy link
Author

blathers-crl bot commented Oct 24, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from michae2 and rafiss October 24, 2024 10:48
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 24, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@spilchen spilchen merged commit 0cdee99 into release-24.3 Oct 24, 2024
19 of 21 checks passed
@spilchen spilchen deleted the blathers/backport-release-24.3-133130 branch October 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants