storage: add TestKeySchema_RandomKeys #133077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
reviewed
Oct 21, 2024
| it.InitOnce(keySchema, EngineKeyCompare, EngineKeySplit, nil) | ||
| require.NoError(t, it.Init(&dec, block.NoTransforms)) | ||
| for k, kv := 0, it.First(); kv != nil; k, kv = k+1, it.Next() { | ||
| require.True(t, EngineKeyEqual(keys[k], kv.K.UserKey)) |
There was a problem hiding this comment.
Should we compare for exact equality? We assume that the keys will be identical (or at least never longer) when we preallocate the max-key-length buffer
There was a problem hiding this comment.
Added an assertion on the length. This test will generate MVCC keys with the synthetic bit so we can't assert exact equality
Add a randomized test that constructs random keys, writes them to a Pebble columnar block, iterates over the block and asserts that the keys are semantically equal to the original generated keys. Epic: none Release note: none
jbowens
force-pushed
the
randomized-test
branch
from
b1dcf6c to
abfe387
Compare
RaduBerinde
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)
pkg/storage/pebble_key_schema_test.go line 349 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
Added an assertion on the length. This test will generate MVCC keys with the synthetic bit so we can't assert exact equality
👍
|
TFTR! bors r=RaduBerinde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a randomized test that constructs random keys, writes them to a Pebble columnar block, iterates over the block and asserts that the keys are semantically equal to the original generated keys.
Epic: none
Release note: none