roachtest: default sysbench to --rand-type=uniform #132664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sysbench` at 1.0.20 (the latest release) uses its own "special" built-in rand-type. This has hotspots and is generally unpleasant and poorly understood. Vendors generally recommend using `uniform`[1], which we now default to (I'll add a roachperf annotation). In addition, the next release of sysbench - should it ever come, it's been four years - will _remove_ the "special" distribution and default to uniform as well. [^1]: https://docs.pingcap.com/tidb/stable/benchmark-tidb-using-sysbench Epic: none Release note: None
|
This change is |
tbg
requested review from
herkolategan and
vidit-bhat
and removed request for
a team
|
Annotation PR is https://github.com/cockroachdb/roachperf/pull/176 |
nvanbenschoten
approved these changes
Oct 16, 2024
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysbenchat 1.0.20 (the latest release) uses its own "special"built-in rand-type. This has hotspots and is generally unpleasant
and poorly understood.
Vendors generally recommend using
uniform1, which we now default to(I'll add a roachperf annotation). In addition, the next release of
sysbench - should it ever come, it's been four years - will remove the
"special" distribution and default to uniform as well.
Epic: none
Release note: None
Footnotes
https://docs.pingcap.com/tidb/stable/benchmark-tidb-using-sysbench ↩