allocatorimpl: vlog on all excl. repl due to catchup conditions #132603
Conversation
|
This change is |
Add `String()` and `SafeFormat()` methods for `RangeSendStreamStats` and `ReplicaSendStreamStats`. Part of: cockroachdb#123509 Release note: None
Previously, we would only `VEventf(ctx, 5, ...)` when a replica was being excluded due to having a send queue, or not being in `StateReplicate`. Now also: - `V(4)` log when a replica is included due to missing stats. - `V(6)` log when a replica is included due to passing stats. Part of: cockroachdb#123509 Release note: None
kvoli
force-pushed
the
241014.rac2-send-stream-stats-logging
branch
from
e98f773 to
2bacf24
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kvoli)
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller.go line 224 at r1 (raw file):
w.Printf(", ") } w.Printf("r%v=(%v)", s.internal[i].ReplicaID, s.internal[i])
Is the convention that the r prefix is used only for the range-id?
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller.go line 1436 at r1 (raw file):
panic(errors.AssertionFailedf("statsToSet is non-empty %v", statsToSet.internal)) } statsToSet.Clear()
was this unnecessary because of:
// INVARIANT: len(stats.internal) = 0.
There was a problem hiding this comment.
TYFTR!
bors r=sumeerbhola
Reviewable status:
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller.go line 224 at r1 (raw file):
Previously, sumeerbhola wrote…
Is the convention that the r prefix is used only for the range-id?
I've seen it also used for replicas in some contexts, the allocator being one of them.
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller.go line 1436 at r1 (raw file):
Previously, sumeerbhola wrote…
was this unnecessary because of:
// INVARIANT: len(stats.internal) = 0.
Yeah -- I forgot to add this originally.
|
blathers backport 24.3 |
Previously, we would only
VEventf(ctx, 5, ...)when a replica wasbeing excluded due to having a send queue, or not being in
StateReplicate.Now also:
V(4)log when a replica is included due to missing stats.V(6)log when a replica is included due to passing stats.Also, stop shadowing the range stat declaration with the replica
stat declaration within the loop.
Part of: #123509
Release note: None