Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: run perf tests with sql and kv mode #132341

Merged
merged 1 commit into from
Oct 10, 2024
Merged

roachtest: run perf tests with sql and kv mode #132341

merged 1 commit into from
Oct 10, 2024

Conversation

msbutler
Copy link
Collaborator

Epic: none

Release note: none

@msbutler
roachtest: run perf tests with sql and kv mode
904f0ed 
Epic: none

Release note: none
@msbutler msbutler requested review from dt and jeffswenson October 10, 2024 19:34
@msbutler msbutler self-assigned this Oct 10, 2024
@msbutler msbutler requested a review from a team as a code owner October 10, 2024 19:34
@msbutler msbutler requested review from herkolategan and srosenberg and removed request for a team October 10, 2024 19:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

jeffswenson
jeffswenson approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msbutler
Copy link
Collaborator Author

TFTR!

bors r=jeffswenson

@craig
Copy link
Contributor

craig bot commented Oct 10, 2024

Build succeeded:

@craig craig bot merged commit a69a2f3 into cockroachdb:master Oct 10, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffswenson jeffswenson jeffswenson approved these changes

@dt dt Awaiting requested review from dt

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan was automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg was automatically assigned from cockroachdb/test-eng

Assignees

@msbutler msbutler

Labels
T-disaster-recovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbutler @cockroach-teamcity @jeffswenson