Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql/row: fix updates of single-composite-column families #132122

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

michae2
Copy link
Collaborator

@michae2 michae2 commented Oct 7, 2024

Backport 1/1 commits from #131869.

/cc @cockroachdb/release


sql/row: fix updates of single-composite-column families

When updating a single-column family which contains what could be a composite value from the primary key, we still need to issue a Del even if the new value for the column is not composite, because the previous value might have been composite.

Fixes: #131860

Release note (bug fix): Fix a rare bug in which an update of a primary key column which is also the only column in a separate column family can sometimes fail to update the primary index. This bug has existed since v22.2. Requirements to hit the bug are:

  1. A table with multiple column families.
  2. A column family containing a single PK column.
  3. That column family is not the first column family.
  4. That column family existed before its column was in the PK.
  5. That column must be of type FLOAT4/8, DECIMAL, JSON, collated string type, or array.
  6. An update that changes that column from a composite value to a non-composite value.

Release justification: low-risk fix for a rare corruption bug.

@michae2 michae2 requested a review from a team as a code owner October 7, 2024 21:00
Copy link

blathers-crl bot commented Oct 7, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 7, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@michae2 michae2 force-pushed the backport24.1-132120 branch 2 times, most recently from f4b27e5 to 8656e17 Compare October 10, 2024 16:48
When updating a single-column family which contains what could be a
composite value from the primary key, we still need to issue a Del even
if the new value for the column is not composite, because the previous
value might have been composite.

Fixes: cockroachdb#131860

Release note (bug fix): Fix a rare bug in which an update of a primary
key column which is also the only column in a separate column family can
sometimes fail to update the primary index. This bug has existed since
v22.2. Requirements to hit the bug are:

1. A table with multiple column families.
2. A column family containing a single PK column.
3. That column family is not the first column family.
4. That column family existed before its column was in the PK.
5. That column must be of type FLOAT4/8, DECIMAL, JSON, collated string
   type, or array.
6. An update that changes that column from a composite value to a non-
   composite value.
@michae2 michae2 force-pushed the backport24.1-132120 branch from 8656e17 to 92b0ca0 Compare October 16, 2024 21:44
@michae2 michae2 merged commit d2177e0 into cockroachdb:release-24.1 Oct 17, 2024
19 of 20 checks passed
@michae2 michae2 deleted the backport24.1-132120 branch October 17, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants